Code refactoring

Reviewed-on: https://git.trom.tf/TROMjaro/theme-switcher-package/pulls/6

Makefile

@@ -1,12 +1,12 @@
-# makefile for theme-switcher
+# makefile for tromjaro-theme-switcher
 build:
-	makepkg
+	makepkg -s
 
 install:
-	pamac-installer theme-switcher-*.tar.xz
+	pamac-installer tromjaro-theme-switcher-*.tar.zst
 
 remove:
-	pamac-installer --remove theme-switcher
+	pamac-installer --remove tromjaro-theme-switcher
 
 clean:
-	$(RM) -rf src/ pkg/ *.tar.xz
+	$(RM) -rf src/ pkg/ icons.tar.gz *.tar.zst

PKGBUILD

@@ -1,7 +1,7 @@
 # Maintainer: TROM <contact@tromsite.com>
 pkgname=tromjaro-theme-switcher
-pkgver=1.4
+pkgver=3
-pkgrel=3
+pkgrel=4
 pkgdesc="TROMjaro Theme switcher application"
 arch=('x86_64')
 url="https://git.trom.tf/TROMjaro/theme-switcher-package"
@@ -10,6 +10,11 @@ depends=('tromjaro-fixes'
          'xfconf'
          'gtk4'
          'colloid-gtk-theme-git'
+         'colloid-dracula-gtk-theme-git'
+         'colloid-gruvbox-gtk-theme-git'
+         'colloid-nord-gtk-theme-git'
+         'colloid-everforest-gtk-theme-git'
+         'colloid-catppuccin-gtk-theme-git'
          'zafiro-icon-theme')
 makedepends=('choosenim')
 provides=('tromjaro-theme-switcher')
@@ -18,18 +23,25 @@ options=(!strip)
 source=("themeSwitcher.nim"
         "tromjaro-theme-switcher.desktop"
         "tromjaro-theme-switcher.svg"
-        "icons.zip::https://www.drive.tromsite.com/s/zFtCp3SkZ4NpKix/download")
+        "icons.tar.gz::https://www.drive.tromsite.com/s/ysM33nJAkpro85b/download/icons.tar.gz")
 sha256sums=('SKIP'
 'SKIP'
 'SKIP'
 'SKIP')
 prepare() {
+	# Disable telemetry in choosenim if user is running it for the first time
+	[ -f "$HOME"/.choosenim/analytics ] || {
+		mkdir -p "$HOME"/.choosenim
+		touch "$HOME"/.choosenim/analytics
+	}
 	echo 'Install Nim if not already installed:'
 	choosenim stable
 	echo 'Update Nim to the latest stable release:'
 	choosenim update stable
+	echo 'Refresh nimble package list:'
+	"$HOME"/.nimble/bin/nimble --nim:"$HOME"/.nimble/bin/nim refresh
 	echo 'Install owlkettle from the latest git commit:'
-    "$HOME"/.nimble/bin/nimble install owlkettle@#head
+	"$HOME"/.nimble/bin/nimble --nim:"$HOME"/.nimble/bin/nim install owlkettle
 }
 build(){
 	echo 'Compile themeSwitcher.nim for release build:'
@@ -37,8 +49,14 @@ build(){
 }
 package() {
 	# copy icons
-    install -d ${pkgdir}/usr/share/tromjaro-theme-switcher/icons
+	install -d ${pkgdir}/usr/share/tromjaro-theme-switcher/icons/Styles
-    install -Dm644 ${srcdir}/icons/*    ${pkgdir}/usr/share/tromjaro-theme-switcher/icons
+	install -Dm644 ${srcdir}/icons/Styles/*    ${pkgdir}/usr/share/tromjaro-theme-switcher/icons/Styles
+
+	for source_dir in "${srcdir}/icons/Accent Colors"/*; do
+		dest_dir="${pkgdir}/usr/share/tromjaro-theme-switcher/icons/Accent Colors/${source_dir##*/}"
+		install -d "$dest_dir"
+		install -Dm644 "$source_dir"/*    "$dest_dir"
+	done
 
 	# copy executables
 	install -Dm644  ${srcdir}/tromjaro-theme-switcher.desktop    ${pkgdir}/usr/share/applications/tromjaro-theme-switcher.desktop

README.md

@@ -1,6 +1,8 @@
-# TROMjaro Theme switcher package
+# TROMjaro Theme switcher
 
-TROMjaro Theme switcher application
+A Theme Switcher app for TROMjaro's default theme-set ([Colloid](https://github.com/vinceliuice/Colloid-gtk-theme)) and icon-set ([Zafiro](https://github.com/zayronxio/Zafiro-icons)). It gives you a nice and easy interface to try out different themes quickly.
+
+<video width="720" height="480" controls autoplay title="Screen recording of the app in action" src="https://git.trom.tf/TROMjaro/theme-switcher-package/raw/branch/main/screenRecord.mp4" type="video/mp4"></video>
 
 ## Building the package
 
@@ -16,6 +18,6 @@ To remove just installed package, use:
 
 `make remove`
 
-To cleanup the project, use:
+To cleanup the project folder, use:
 
 `make clean`

themeSwitcher.nim

@@ -1,125 +1,169 @@
-from std/osproc import execProcess, ProcessOption, startProcess, waitForExit, close
+from std/os import symlinkExists, getConfigDir, walkDirs, `/`
-from std/os import symlinkExists, getConfigDir, putEnv, `/`
+from std/envvars import existsEnv, getEnv, delEnv, putEnv
-from std/strutils import split, endsWith, strip
+from std/options import Option, some, get, isNone
-from std/algorithm import fill
 from std/strformat import fmt
-import owlkettle
+import pkg/owlkettle
+import ./themes
 
 const
   # Set the directory path where icons are stored
   iconsDir = "/usr/share/tromjaro-theme-switcher/icons"
+  styleIconsDir = iconsDir / "Styles"
+  accentIconsDir = iconsDir / "Accent Colors"
   # GTK CSS for overriding the default icon size of buttons
-  gtkCSS = "button { -gtk-icon-size: 22mm; }"
+  gtkCSS = """
-  themeColors = ["Grey", "Pink", "Green", "Orange", "Purple", "Yellow", "Teal"]
+.style-button {
-  themeStyles = ["Light", "Nord", "Dark", "Dark-Nord"]
+  min-width: 5.5em;
+  min-height: 5em;
+  padding: 0.3em;
+  border-radius: 14%;
+}
 
-proc runCommand(command: string, args: openArray[string]): bool =
+.accent-button {
-  ## This will run a command with the given args and return true upon success
+  -gtk-icon-size: 1.65em;
-  let process = startProcess(command, args=args, options={poParentStreams})
+  padding: 0.4em;
-  result = process.waitForExit() == 0
+  border-radius: 50%;
-  process.close()
+}
+"""
 
-proc setIconTheme(iconName: string) =
+var iconsDirs: seq[string]
-  # Change icon theme in XFCE
-  discard runCommand("/usr/bin/xfconf-query",
-    args=["--channel=xsettings", "--property=/Net/IconThemeName", "--create", "--type=string", "--set", iconName])
 
-proc enableDarkPanels(): bool =
+for dir in walkDirs(accentIconsDir / "*"):
-  # Return if dark panels is already enabled
+  iconsDirs.add(dir)
-  if execProcess("/usr/bin/xfconf-query",
-    args=["--channel=xfce4-panel", "--property=/panels/dark-mode"], options={}) == "true\n":
-    return
-  # Try to enable it and return true upon success
-  result = runCommand("/usr/bin/xfconf-query",
-    args=["--channel=xfce4-panel", "--property=/panels/dark-mode", "--create", "--type=bool", "--set=true"])
 
-proc setTheme(themeName: string) =
+# Function prototypes
+proc makeThemeButton(shadeName: string, styleName: string): Widget
+proc makeAccentButton(accentColor: string): Widget
+proc accentButtons(): Widget
+proc themeButtons(): Widget
+proc mainGUI(): Widget
 
-  var panelNotification: string
+# Keep track of current theme button
-
+var currentTheme = getCurrentTheme()
-  # Set the icon theme and panel color according to the chosen theme
-  if themeName.endsWith("-Dark") or themeName.endsWith("-Dark-Nord"):
-    setIconTheme("zafiro-dark")
-  else:
-    setIconTheme("zafiro")
-    if enableDarkPanels():
-      panelNotification = " with dark panels"
-
-  # Change the main theme to the chosen one
-  discard runCommand("/usr/bin/xfconf-query",
-    args=["--channel=xsettings", "--property=/Net/ThemeName", "--create", "--type=string", "--set", themeName])
-
-  # Send notification about the theme change
-  sendNotification("com.tromjaro.ThemeSwitcher", "Theme Switcher", fmt"{themeName} theme{panelNotification} is enabled",
-    icon=fmt"{iconsDir}/{themeName}.svg")
 
+var
+  oldConfigDir: Option[string]
+  configDirChanged: bool
 
 # Prevent loading GTK theme from ~/.config/gtk-4.0 directory when it is a symlink
 if symlinkExists(getConfigDir() / "gtk-4.0"):
+  if existsEnv("XDG_CONFIG_HOME"):
+    oldConfigDir = some(getEnv("XDG_CONFIG_HOME"))
   putEnv("XDG_CONFIG_HOME", "/dev/null")
-
+  configDirChanged = true
-var
-  lastClickedButton: array[2, int]
 
 # Display the GTK-4 GUI using owlkettle
+
 viewable App:
-  # 2D array storing the style for each button
-  buttonStyles: array[themeStyles.len(),array[themeColors.len(), StyleClass]]
   hooks:
     build:
-      # Make all buttons flat by default
+      # Reset the user's XDG_CONFIG_HOME variable back to what it was before
-      for index in 0..state.buttonStyles.high():
+      if configDirChanged == true:
-        fill(state.buttonStyles[index], ButtonFlat)
+        if oldConfigDir.isNone():
-
+          delEnv("XDG_CONFIG_HOME")
-      let currentTheme: string = execProcess("/usr/bin/xfconf-query",
+        else:
-        args=["--channel=xsettings", "--property=/Net/ThemeName"],
+          putEnv("XDG_CONFIG_HOME", get(oldConfigDir))
-        options={}).strip(leading=false, trailing=true, chars={'\n'})
-
-      let currentThemeSplit: seq[string] = currentTheme.split('-', 2)
-
-      if currentThemeSplit.len() < 3 or currentThemeSplit[0] != "Colloid":
-        return
-
-      let currentThemeColorIndex = find(themeColors, currentThemeSplit[1])
-      let currentThemeStyleIndex = find(themeStyles, currentThemeSplit[2])
-
-      if -1 in [currentThemeColorIndex, currentThemeStyleIndex]:
-        return
-
-      # Highlight current theme button
-      state.buttonStyles[currentThemeStyleIndex][currentThemeColorIndex] = ButtonSuggested
-      lastClickedButton = [currentThemeStyleIndex, currentThemeColorIndex]
 
 method view(app: AppState): Widget =
+  result = mainGUI()
+
+brew(appID, gui(App()), icons=iconsDirs, stylesheets=[newStylesheet(gtkCSS)])
+
+
+# Function declarations
+
+proc makeThemeButton(shadeName: string, styleName: string): Widget =
+  let
+    shade = if shadeName == "": "" else: fmt"-{shadeName}"
+    style = if styleName == "Default": "" else: fmt"-{styleName}"
+    color = if currentTheme.color in ["Blue", ""]: "" else: fmt"-{currentTheme.color}"
+    themeString = fmt"Colloid{color}{shade}{style}"
+
   result = gui:
+    Button:
+      Picture:
+        pixbuf = loadPixbuf(fmt"{styleIconsDir}/Colloid{shade}{style}.svg")
+      tooltip = if shadeName == "": styleName else: fmt"{shadeName}-{styleName}"
+      style = if (shadeName, styleName) == (currentTheme.shade, currentTheme.style):
+        [StyleClass("style-button"), ButtonSuggested]
+      else:
+        [StyleClass("style-button"), ButtonFlat]
+
+      proc clicked() =
+        setTheme(themeString)
+        # Highlight this button
+        currentTheme.shade = shadeName
+        currentTheme.style = styleName
+        if currentTheme.color == "":
+          currentTheme.color = "Blue"
+
+proc makeAccentButton(accentColor: string): Widget =
+  let
+    shade = if currentTheme.shade == "": "" else: fmt"-{currentTheme.shade}"
+    style = if currentTheme.style in ["Default", ""]: "" else: fmt"-{currentTheme.style}"
+    color = if accentColor == "Blue": "" else: fmt"-{accentColor}"
+    themeString = fmt"Colloid{color}{shade}{style}"
+
+  result = gui:
+    Button:
+      icon = fmt"{accentColor}{style}{shade}"
+      tooltip = accentColor
+      style = if accentColor == currentTheme.color:
+          [StyleClass("accent-button"), ButtonSuggested]
+        else:
+          [StyleClass("accent-button"), ButtonFlat]
+
+      proc clicked() =
+        setTheme(themeString)
+        # Highlight this button
+        currentTheme.color = accentColor
+        if currentTheme.style == "":
+          currentTheme.style = "Default"
+
+proc themeButtons(): Widget =
+  gui:
+    # Vertical box
+    Box(orient = OrientY, spacing = 5):
+      for shadeName in themeShades:
+        # Horizontal box
+        Box(orient = OrientX, spacing = 5):
+          for styleName in themeStyles:
+            let themeButton = makeThemeButton(shadeName, styleName)
+            insert(themeButton) {.vAlign: AlignCenter, hAlign: AlignCenter.}
+
+proc accentButtons(): Widget =
+  gui:
+    # Horizontal box
+    Box(orient = OrientX, spacing = 3):
+      for accentColor in accentColors:
+        let accentButton = makeAccentButton(accentColor)
+        insert(accentButton) {.vAlign: AlignCenter, hAlign: AlignCenter.}
+
+proc mainGUI(): Widget =
+  gui:
     Window:
       title = "TROMjaro Theme Switcher"
       # Shrink window to the smallest size
-      defaultSize = (0, 0)
+      defaultSize = (1, 1)
+      iconName = appLogo
       # Vertical box
-      Box(orient = OrientY, margin = 7, spacing = 5):
+      Box(orient = OrientY, margin = 13, spacing = 10):
+        Label:
+          useMarkup=true
+          text="<span size='large'>STYLE</span>"
+        # Theme buttons
+        insert(themeButtons())
+        Separator(margin = Margin(top: 5)) {.vAlign: AlignCenter.}
+        Label:
+          useMarkup=true
+          text="<span size='large'>ACCENT COLOR</span>"
+        # Accent buttons
+        insert(accentButtons())
+        Separator(margin = Margin(top: 12)) {.vAlign: AlignCenter.}
+        # Vertical box
+        Box(orient = OrientY):
           Label:
             text="A Theme Switcher for TROMjaro's default theme-set (Colloid) and icon-set (Zafiro)."
-        for y, themeStyle in themeStyles:
+          Label {.vAlign: AlignStart.}:
-          # Horizontal box
+            useMarkup = true
-          Box(orient = OrientX, spacing = 5):
+            text="<span size='small'>NOTE: Some apps need to be reopened for the theme to be applied.</span>"
-            for x, themeColor in themeColors:
-              Button {.vAlign: AlignCenter, hAlign: AlignCenter.}:
-                icon = fmt"Colloid-{themeColor}-{themeStyle}"
-                # Teal-Dark-Nord theme will have "(default)" added to its tooltip
-                tooltip = if (themeColor, themeStyle) == ("Teal", "Dark-Nord"):
-                  fmt"{themeColor}-{themeStyle} (default)"
-                else:
-                  fmt"{themeColor}-{themeStyle}"
-                style = app.buttonStyles[y][x]
-                proc clicked() =
-                  var thisButton = [y, x]
-                  setTheme(fmt"Colloid-{themeColor}-{themeStyle}")
-                  # Highlight this button
-                  app.buttonStyles[y][x] = ButtonSuggested
-                  if lastClickedButton != thisButton:
-                    # Remove highlight from lastClickedButton
-                    app.buttonStyles[lastClickedButton[0]][lastClickedButton[1]] = ButtonFlat
-                    lastClickedButton = thisButton
-
-brew("com.tromjaro.ThemeSwitcher", gui(App()), icons=[iconsDir], stylesheets=[newStylesheet(gtkCSS)])

themes.nim

@@ -0,0 +1,111 @@
+from std/osproc import execProcess, ProcessOption, startProcess, waitForExit, close
+from std/strutils import split, endsWith, contains
+from std/strformat import fmt
+import pkg/owlkettle
+
+type Theme = tuple[color, shade, style: string]
+
+const
+  themeShades* = ["Light", "", "Dark"]
+  themeStyles* = ["Default", "Nord", "Dracula", "Catppuccin", "Everforest", "Gruvbox"]
+  accentColors* = ["Blue", "Red", "Purple", "Pink", "Teal", "Green", "Yellow", "Orange", "Grey"]
+  appID* = "com.tromjaro.ThemeSwitcher"
+  appLogo* = "tromjaro-theme-switcher"
+
+proc getCurrentTheme*(): Theme =
+  let currentThemeString = execProcess("/usr/bin/xfconf-query",
+    args=["--channel=xsettings", "--property=/Net/ThemeName"],
+    options={})[0 .. ^2]
+
+  # Split the theme string into words
+  let words = currentThemeString.split('-')
+  if words[0] != "Colloid":
+    return
+  var currentTheme: Theme = (color: "Blue", shade: "", style: "Default")
+
+  case len(words):
+    of 1: discard
+
+    # Match against Colloid-Color, Colloid-Shade, Colloid-Style
+    of 2:
+      let word1 = words[1]
+      if word1 in accentColors:
+        currentTheme.color = word1
+      elif word1 in themeShades:
+        currentTheme.shade = word1
+      elif word1 in themeStyles:
+        currentTheme.style = word1
+      else:
+        return
+
+    # Match against Colloid-Color-Shade, Colloid-Shade-Style
+    of 3:
+      let
+        word1 = words[1]
+        word2 = words[2]
+      if (word1 in accentColors) and (word2 in themeShades):
+        currentTheme.color = word1
+        currentTheme.shade = word2
+      elif (word1 in themeShades) and (word2 in themeStyles):
+        currentTheme.shade = word1
+        currentTheme.style = word2
+      else:
+        return
+
+    # Match against Colloid-Color-Shade-Style
+    of 4:
+      let
+        word1 = words[1]
+        word2 = words[2]
+        word3 = words[3]
+      if (word1 in accentColors) and (word2 in themeShades) and (word3 in themeStyles):
+        currentTheme.color = word1
+        currentTheme.shade = word2
+        currentTheme.style = word3
+      else:
+        return
+
+    else:
+      return
+
+  return currentTheme
+
+proc runCommand(command: string, args: openArray[string]): bool =
+  ## This will run a command with the given args and return true upon success
+  let process = startProcess(command, args=args, options={poParentStreams})
+  result = process.waitForExit() == 0
+  process.close()
+
+proc setIconTheme(iconName: string) =
+  # Change icon theme in XFCE
+  discard runCommand("/usr/bin/xfconf-query",
+    args=["--channel=xsettings", "--property=/Net/IconThemeName", "--create", "--type=string", "--set", iconName])
+
+proc enableDarkPanels(): bool =
+  # Return if dark panels is already enabled
+  if execProcess("/usr/bin/xfconf-query",
+    args=["--channel=xfce4-panel", "--property=/panels/dark-mode"], options={}) == "true\n":
+    return
+  # Try to enable it and return true upon success
+  result = runCommand("/usr/bin/xfconf-query",
+    args=["--channel=xfce4-panel", "--property=/panels/dark-mode", "--create", "--type=bool", "--set=true"])
+
+proc setTheme*(themeName: string) =
+
+  var panelNotification: string
+
+  # Set the icon theme and panel color according to the chosen theme
+  if themeName.endsWith("-Dark") or themeName.contains("-Dark-"):
+    setIconTheme("zafiro-dark")
+  else:
+    setIconTheme("zafiro")
+    if enableDarkPanels():
+      panelNotification = " with dark panels"
+
+  # Change the main theme to the chosen one
+  discard runCommand("/usr/bin/xfconf-query",
+    args=["--channel=xsettings", "--property=/Net/ThemeName", "--create", "--type=string", "--set", themeName])
+
+  # Send notification about the theme change
+  sendNotification(appID, "Theme Switcher", fmt"{themeName} theme{panelNotification} is enabled",
+    icon=appLogo)